Php Codesniffer Sniffs Laravel Package

This library can now be used with slevomat/coding-standard up to version 8.26.0.

This library can now be used with slevomat/coding-standard up to version 8.20.0. Thanks to @Potherca for the patch!

This library can now be used with slevomat/coding-standard up to version 8.15.0.

This library can now be used with slevomat/coding-standard up to version 8.8.0. Thanks @mjrider for the patch.

This library can now be used with slevomat/coding-standard up to version 8.6.2. Thanks @agriemink for the patch.

This library can now be used with slevomat/coding-standard up to version 8.1.0. Thanks @rmikalkenas for the patch.

This library can now be used with slevomat/coding-standard up to version 7.2.1. Thanks @rmikalkenas for the patch.

This library can now be used with slevomat/coding-standard up to version 7.0.18. Thanks @rmikalkenas for the patch.

This library can now be used with slevomat/coding-standard up to version 7.0.15. Thanks @Jeroeny for the patch.

This release adds compatibility with a small set of slevomat/coding-standard 7.0.x releases. See #10 for details.

Added compatibility with PHP 8.

Bumped requirement for slevomat/coding-standard to at least version 6.3.11.

This package is now compatible with slevomat/coding-standard 6.x. Thanks to @Jeroeny for the patch.

New sniff added: MoxioSniffs.PHP.DisallowUtf8EncodeDecode. This sniff disallows calls to utf8_encode() and utf8_decode(). These functions can be considered misleading because they only convert to/from ISO-8859-1, and do not 'magically' detect the source/target encoding. Using iconv() or mb_convert_encoding() instead makes both character encodings that play a role in the conversion explicit.

This project now requires PHP 7.1 or newer.

New sniff added: MoxioSniffs.PHP.DisallowMbDetectEncoding, which disallows usage of mb_detect_encoding. This function has a misleading name that implies it can actually detect the encoding of a string, a problem which is generally impossible. Rather it checks a list of encodings until it finds one that could be the right one (i.e. the string is a valid byte sequence according to that encoding). Using mb_check_encoding (possibly in a loop) instead makes this much more explicit. See this talk for more background information on this topic.

New sniff added: MoxioSniffs.PHP.DisallowDateTime: This sniff disallows usage of \DateTime and promotes the use of \DateTimeImmutable instead. The former being mutable can lead to some subtle but nasty bugs. Thanks to @nikolaposa for the blogpost that inspired this sniff, and to the folks at @slevomat for their great collection of helpers for PHP_CodeSniffer.

This major release contains a backward incompatible change to the 'standard' name (Moxio to MoxioSniffs) and associated namespace (Moxio\Sniffs to Moxio\CodeSniffer\MoxioSniffs\Sniffs). This change is meant to emphasize the character of this 'standard' as a set of pick-and-match sniffs rather than a complete coding standard, and to prevent naming conflicts with our internal company coding standard. Please consult the upgrading instructions.

New sniff added: Moxio.PHP.DisallowImplicitIteratorToArrayWithUseKeys. This sniff disallows calls to iterator_to_array() without the $use_keys argument being explicitly set. By default, iterator_to_array uses the keys provided by the iterator. This behavior is often desired for associative arrays, but can cause unexpected results for 'list-like' arrays. Explicitly requiring the parameter to be set ensures that the developer has to think about which behavior is desired for the situation at hand. Thanks to @hollodotme for drawing our attention to this 'risky' default behavior.

New sniff added: Moxio.PHP.DisallowImplicitLooseBase64Decode. This sniff disallows implicit non-strict usage of the base64_decode function. By default, this function silently discards invalid characters, which may be unexpected and undesirable. Using this sniff, one needs to explicitly opt-in to this behavior, making it a deliberate choice. Thank you @dheineman for this contribution (#5).

This project is now automatically detected by DealerDirect/phpcodesniffer-composer-installer, so that (if that plugin is used) PHP_CodeSniffer can reference the standard by name. Thank you @dheineman for the PR (#4)!

Changed Moxio.PHP.ImplicitLooseComparisonSniff to also apply to array_keys. When called with two or more parameters, array_keys essentially behaves like a multi-valued array_search. For that variant, we now also disallow implicit loose comparisons, like we also already do for array_search. Calls to array_keys with just a single parameter (i.e. without $search_value) are unaffected.

Added new sniff Moxio.PHP.DisallowImplicitMicrotimeAsString. This sniff disallows calls to microtime() without the $get_as_float argument being explicitly set. By default, microtime has a string as its return value ("msec sec"), which is unexpected and cannot be naively cast to float, making it error-prone. It is still possible to set this argument to false, but in that case you have probably thought about this.

Fixed false positives by Moxio.PHP.DisallowArrayCombinersWithSingleArray when using argument unpacking, e.g. array_merge(...$arrays). In general, this allows sniffs extending AbstractFunctionCallSniff to be skipped when such unpacked arguments are present.

Added new sniff Moxio.PHP.DisallowArrayCombinersWithSingleArray. This sniff disallows calls to functions that combine two or more with only a single array given as an argument. This applies to functions like array_merge(_recursive), array_replace(_recursive) and all variants of array_diff and array_intersect. Such a call does not make sense, and is most likely a result of a misplaced comma or parenthesis.

AbstractFunctionCallSniff now correctly handles short array syntax in function call parameters. In particular this fixes #2. Thanks to Ondřej Mirtes (@ondrejmirtes) for reporting this issue.

Added PHPUnit tests.

Added new sniff Moxio.PHP.DisallowUniqidWithoutMoreEntropy. This sniff disallows calls to uniqid() without the $more_entropy parameter being set to true, because such calls can harm performance.

From this release, the sniffs are supported (only) with PHP_CodeSniffer version 3.x.

The sniff classes have been renamed in accordance with the namespacing requirement of PHP_CodeSniffer 3.

• Moxio_Sniffs_PHP_DisallowBareContinueInSwitchSniff -> Moxio\Sniffs\PHP\DisallowBareContinueInSwitchSniff
• Moxio_Sniffs_PHP_DisallowImplicitLooseComparisonSniff -> Moxio\Sniffs\PHP\DisallowImplicitLooseComparisonSniff
• Moxio_Sniffs_Abstract_AbstractFunctionCallSniff -> Moxio\Sniffs\AbstractFunctionCallSniff

Thanks to Petr Bugyík (@o5) for testing this version with the final 3.x release of PHP_CodeSniffer.